Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post/ ember-vite-codemod #2648

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

BlueCutOfficial
Copy link
Contributor

@BlueCutOfficial BlueCutOfficial commented Feb 28, 2025

@BlueCutOfficial BlueCutOfficial force-pushed the blog-post-codemod branch 4 times, most recently from 6c2fa73 to b7c897f Compare February 28, 2025 15:16
Copy link

Ember Vite Codemod

@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review March 4, 2025 08:53
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post overall. I did some tweaking in my suggestions and used some Grammarly to help. Feel free to accept or pass on any of them 👍

Copy link
Contributor

@KevinBongart KevinBongart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! Or, to use typical High French Praise: "not bad". I left a bunch of minor comments, but two things:

  1. These blog posts always need a closing call to action. "Mainmatter's Ember Initiative aims to improve Ember for the entire web. We need your support: talk to your employer about sponsoring our effort, spread the word, and follow our progress on this blog. You can get in touch with us" etc.
  2. I'm not too sure what the goal of this blog post is between:
    • announcing the codemod (great for Ember developers on a recent version who want to upgrade to Vite)
    • explaining what this codemod does and how to use it
    • explaining how this codemod works and how you approached it (and future versions)
    • explaining what codemods are and how to write one for a different problem

You could state clearly in the intro "we are excited to release this codemod, which will make it easier to upgrade to Vite, and we're going to explain what it does and how you can use it" for instance. This is just my opinion, but it feels like it needs some focus one one (maybe two) of these threads

@BlueCutOfficial
Copy link
Contributor Author

Thanks for the review @KevinBongart 🙏 There are a few suggestions that I think could be discussed, but I'll apply most of them tomorrow morning.

@BlueCutOfficial BlueCutOfficial force-pushed the blog-post-codemod branch 2 times, most recently from e36d71a to 14a8995 Compare March 6, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants